Repository navigation
Pillbox: support indicator="checkbox" like flux:select does
#2872
Unanswered
kobykorman
asked this question in
Feature Requests
Replies: 0 comments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Uh oh!
There was an error while loading. Please reload this page.
flux:select variant="listbox" multipleacceptsindicator="checkbox", so a multiple select shows empty boxes on every row. You can tell it takes several values before the first pick.flux:pillboxis always multiple, but it has no indicator setting: its rows show the checkmark only, which appears only once a row is picked. Until then, a pillbox's pane looks the same as a single select's.The pillbox is already half-wired for this.
pillbox/options.blade.phpdeclares anindicatorprop, but nothing reads it:pillbox/option.blade.phprenders a fixed<flux:pillbox.indicator />, whose only look is the check.Suggested change (mirrors what
select.optionalready does):flux:pillboxacceptsindicatorand makes it available to its options, the wayflux:selectdoes.pillbox/option.blade.php:pillbox.indicatorthe samecheck/checkbox/radiovariants asselect.indicator)indicatorto the option'sunsafelist, as Fix Blaze safe list in select option #2626 did forselect.option, so a bound value (:indicator="...") isn't folded away.It already works when placed by hand. Putting
<flux:select.indicator variant="checkbox" />inside a pillbox option's slot renders correctly, since the indicator keys offui-option[data-selected]. That takes one CSS override to hide the built-in check column, which is what we're shipping as a stopgap until this lands.Flux 2.21.0 (livewire/flux-pro 2.21.0), Livewire 4.4.8.
All reactions