Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

filter complex order is not correct #285

Closed
lucemia opened this issue Feb 17, 2024 · 2 comments · Fixed by #286
Closed

filter complex order is not correct #285

lucemia opened this issue Feb 17, 2024 · 2 comments · Fixed by #286

Comments

@lucemia
Copy link
Contributor

lucemia commented Feb 17, 2024

problem

          https://console.cloud.google.com/cloud-build/builds;region=global/44566b05-4999-4b96-b369-19f8989491fd;step=4?project=living-bio

src/composer/tasks/tests/test_gmovie.py::test_parallel_concat_compose_mode[True-5-3-audio-4]

ffmpeg -y -nostdin -i /tmp/pytest-of-root/pytest-0/test_parallel_concat_compose_m2/test_gmovie/test-5sec.mp4 -i /tmp/pytest-of-root/pytest-0/test_parallel_concat_compose_m2/test_gmovie/R8ZRCXy5vhA.m4a -i /tmp/tmp87e39l3y/tmp6mv3ps51.flac -filter_complex '[0]afifo[s0];[1]apad[s1];[s7]apad[s10];[s9][s10][s8][s1][2]amix=inputs=5:duration=first:dropout_transition=0:weights=0 0.25 1.0 1.0 1.0[s11];[s11]dynaudnorm=gausssize=3:maxgain=10[s12];[s0]asplit=outputs=3[s2#0][s2#1][s2#2];[s2#0]adelay=delays=4000:all=1[s3];[s2#1]adelay=delays=8000:all=1[s4];[s2#2]atrim=end=4.0[s5];[s3]atrim=end=8.0[s6];[s4]atrim=end=12.0[s7];[s5]apad[s8];[s6]apad[s9]' -map '[s12]' -c:a flac /tmp/tmp87e39l3y/tmpl_o9xqp7.flac

this command halt

org command

'ffmpeg', '-i', '/tmp/tmpe21o6hf0.flac', '-i', '/tmp/pytest-of-root/pytest-0/test_parallel_concat_compose_m2/test_gmovie/R8ZRCXy5vhA.m4a', '-i', '/tmp/pytest-of-root/pytest-0/test_parallel_concat_compose_m2/test_gmovie/test-5sec.mp4', '-filter_complex', '[1]apad[s0];[2]asplit=3[s1][s2][s3];[s1]afifo[s4];[s4]atrim=end=4.0[s5];[s5]apad[s6];[s2]afifo[s7];[s7]adelay=all=1:delays=4000[s8];[s8]atrim=end=8.0[s9];[s9]apad[s10];[s3]afifo[s11];[s11]adelay=all=1:delays=8000[s12];[s12]atrim=end=12.0[s13];[s13]apad[s14];[0][s0][s6][s10][s14]amix=dropout_transition=0:duration=first:inputs=5:weights=0 0.25 1.0 1.0 1.0[s15];[s15]dynaudnorm=g=3:maxgain=10[s16]', '-map', '[s16]', '-c:a', 'flac', '/tmp/tmpal09y8um.flac', '-nostdin', '-y']

Originally posted by @lucemia in #263 (comment)

@lucemia
Copy link
Contributor Author

lucemia commented Feb 17, 2024

原本的 order 是 based on Node's label

'[0]afifo[s0];[1]apad[s1];[s7]apad[s10];[s9][s10][s8][s1][2]amix=inputs=5:duration=first:dropout_transition=0:weights=0 0.25 1.0 1.0 1.0[s11];[s11]dynaudnorm=gausssize=3:maxgain=10[s12];[s0]asplit=outputs=3[s2#0][s2#1][s2#2];[s2#0]adelay=delays=4000:all=1[s3];[s2#1]adelay=delays=8000:all=1[s4];[s2#2]atrim=end=4.0[s5];[s3]atrim=end=8.0[s6];[s4]atrim=end=12.0[s7];[s5]apad[s8];[s6]apad[s9]'

s0, s1, s10, s11, s12, s3 ....

@lucemia
Copy link
Contributor Author

lucemia commented Feb 17, 2024

修改後

ffmpeg -y -nostdin -i /tmp/tmp1ysju7r6/tmp6hyvhd25.flac -i /tmp/pytest-of-root/pytest-9/test_parallel_concat_compose_m0/test_gmovie/R8ZRCXy5vhA.m4a -i /tmp/pytest-of-root/pytest-9/test_parallel_concat_compose_m0/test_gmovie/test-5sec.mp4 -filter_complex '[1]apad[s0];[2]afifo[s1];[s1]asplit=outputs=3[s2#0][s2#1][s2#2];[s2#0]atrim=end=4.0[s3];[s2#1]adelay=delays=4000:all=1[s4];[s2#2]adelay=delays=8000:all=1[s5];[s3]apad[s6];[s4]atrim=end=8.0[s7];[s5]atrim=end=12.0[s8];[s8]apad[s10];[s7]apad[s9];[0][s0][s6][s9][s10]amix=inputs=5:duration=first:dropout_transition=0:weights=0 0.25 1.0 1.0 1.0[s11];[s11]dynaudnorm=gausssize=3:maxgain=10[s12]' -map '[s12]' -c:a flac /tmp/tmp1ysju7r6/tmp4qsgl3x5.flac

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant