Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix #351 use factory method to generate FilterNode #367

Merged
merged 7 commits into from
Mar 15, 2024

Conversation

lucemia
Copy link
Contributor

@lucemia lucemia commented Mar 14, 2024

fix #351, create a factory method

@lucemia lucemia changed the title use factory fix #351 use factory method to generate FilterNode Mar 14, 2024
Copy link

codecov bot commented Mar 14, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.17%. Comparing base (0db67f0) to head (298c2ef).

❗ Current head 298c2ef differs from pull request most recent head b3d6dc1. Consider uploading reports for the commit b3d6dc1 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #367      +/-   ##
==========================================
- Coverage   97.59%   97.17%   -0.43%     
==========================================
  Files          42       43       +1     
  Lines        1540     1558      +18     
==========================================
+ Hits         1503     1514      +11     
- Misses         37       44       +7     
Flag Coverage Δ
3.10 97.17% <100.00%> (-0.43%) ⬇️
3.11 97.17% <100.00%> (-0.43%) ⬇️
3.12 97.17% <100.00%> (-0.43%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

* fix #349 auto input variable

* add list-all utils in cache

* fix concat filter

* add test case for auto

* fix concat's schema

* update test case

* update test case

* remove not used code
@lucemia lucemia marked this pull request as ready for review March 15, 2024 03:02
@lucemia lucemia merged commit ccf2505 into main Mar 15, 2024
7 checks passed
@lucemia lucemia deleted the fix-351-create-filter-factory branch March 15, 2024 03:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Create a Filter Factory
1 participant