Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix #380 option typing #382

Merged
merged 2 commits into from
Mar 28, 2024
Merged

fix #380 option typing #382

merged 2 commits into from
Mar 28, 2024

Conversation

lucemia
Copy link
Contributor

@lucemia lucemia commented Mar 28, 2024

fix #380 allow more flexible option typing

Copy link

codecov bot commented Mar 28, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.45%. Comparing base (f5eead2) to head (2fcf92b).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #382   +/-   ##
=======================================
  Coverage   98.45%   98.45%           
=======================================
  Files          45       45           
  Lines        1751     1753    +2     
=======================================
+ Hits         1724     1726    +2     
  Misses         27       27           
Flag Coverage Δ
3.10 98.45% <100.00%> (+<0.01%) ⬆️
3.11 98.45% <100.00%> (+<0.01%) ⬆️
3.12 98.45% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@lucemia lucemia marked this pull request as ready for review March 28, 2024 02:15
@lucemia lucemia merged commit b302287 into main Mar 28, 2024
9 checks passed
@lucemia lucemia deleted the fix-380-option-typing branch March 28, 2024 02:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Argument "r" to "output" of "OutputArgs" has incompatible type "int"; expected "str | None"Mypyarg-type
1 participant