Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

create EntryHistory component and place it in EntryDisplay #371

Draft
wants to merge 62 commits into
base: main
Choose a base branch
from

Conversation

Danble
Copy link
Collaborator

@Danble Danble commented Oct 25, 2023

Relevant Issue

(prepend "closes" if issue will be closed by PR)

Summarize what changed in this PR (for developers)

How can the changes be tested?

Please also provide applicable links using relative paths from root (e.g. /apatani/entries) and reviewers can just add that onto preview urls or localhost.

Checklist before marking ready to merge

Please keep it in draft mode until these are completed:

  • Equal time was spent cleaning the code as writing it (Boy Scout Rule)
    • Functions
      • Functions that don't belong in Svelte components are extracted out into .ts files
      • Functions are short and well named
      • Concise tests are written for all functions
    • Classes (a Svelte Component is a Class)
      • Svelte components are broken down into smaller components so that each component is responsible for one thing (Single Responsibility Principle)
      • Stories/variants are written to describe use cases
    • Comments are only included when absolutely necessary information that cannot be explained in code is needed

@vercel
Copy link

vercel bot commented Oct 25, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
living-dictionaries ✅ Ready (Inspect) Visit Preview Dec 15, 2023 6:46pm

Copy link

⚡️Lighthouse report

Average score across 3 targets: 80.8%

Results for https://living-dictionaries-bfpc1i7kz-livingtongues.vercel.app/ (see detailed report)

Category Score
🔴 Performance 34
🟢 Accessibility 90
🟢 Best practices 92
🟢 SEO 96
🟢 PWA 90

Results for https://living-dictionaries-bfpc1i7kz-livingtongues.vercel.app/achi/entries/list (see detailed report)

Category Score
🔴 Performance 43
🟠 Accessibility 88
🟠 Best practices 83
🟢 SEO 100
🟢 PWA 90

Results for https://living-dictionaries-bfpc1i7kz-livingtongues.vercel.app/jaRhn6MAZim4Blvr1iEv/entry/yt9ja7ymh9xgba5i (see detailed report)

Category Score
🟠 Performance 69
🟠 Accessibility 89
🟠 Best practices 83
🟢 SEO 100
🟢 PWA 90

Copy link

Visual Regression Report

22 changed snapshots for living-dictionaries
new old diff
lib/components/home/SelectedDict - Displays_last_update-desktop-en
actual-img
lib/components/home/SelectedDict - Displays_last_update-mobile-en
actual-img
lib/components/home/SelectedDict - Normal-desktop-en
actual-img
lib/components/home/SelectedDict - Normal-mobile-en
actual-img
routes/[dictionaryId]/entries/print/PrintEntry - complex-400x700-fr
actual-img expected-img diff-img
routes/[dictionaryId]/entry/[entryId]/EntryDisplay - Custom_imported_semantic_domain-Desktop-fr
actual-img expected-img diff-img
routes/[dictionaryId]/entry/[entryId]/EntryDisplay - 2_senses-Desktop-fr
actual-img expected-img diff-img
routes/[dictionaryId]/entry/[entryId]/EntryDisplay - History-Desktop-en
actual-img
routes/[dictionaryId]/entry/[entryId]/EntryDisplay - History-Mobile-en
actual-img
routes/[dictionaryId]/entry/[entryId]/EntryHistory - Lexeme_history_authorized-desktop-en
actual-img
routes/[dictionaryId]/entry/[entryId]/EntryHistory - Lexeme_history_authorized-mobile-en
actual-img
routes/[dictionaryId]/entry/[entryId]/EntryHistory - Lexeme_history_unauthorized-desktop-en
actual-img
routes/[dictionaryId]/entry/[entryId]/EntryHistory - Lexeme_history_unauthorized-mobile-en
actual-img
routes/[dictionaryId]/entry/[entryId]/SupaSense - 0-400x400-fr
actual-img expected-img diff-img
routes/[dictionaryId]/entry/[entryId]/SupaSense - cannot_edit__full-400x400-fr
actual-img expected-img diff-img
routes/[dictionaryId]/entry/[entryId]/SupaSense - cannot_edit__not_much-400x400-fr
actual-img expected-img diff-img
routes/[dictionaryId]/entry/[entryId]/SupaSense - empty-400x400-fr
actual-img expected-img diff-img
routes/[dictionaryId]/entry/[entryId]/+page - Editor-786x500-fr
actual-img expected-img diff-img
routes/[dictionaryId]/history/+page - Modifies_notes-300x500-en
actual-img
routes/[dictionaryId]/history/+page - Modifies_notes-700x550-en
actual-img
routes/[dictionaryId]/history/+page - Sorted_by_latest_update-300x500-en
actual-img
routes/[dictionaryId]/history/+page - Sorted_by_latest_update-700x550-en
actual-img

View detailed Playwright Report

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants