[DONE] Fix authentication in Django 2.1 #76
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
reinout
approved these changes
Nov 1, 2018
|
Wat mij betreft mag je 'em releasen. |
|
Ter info: ik ben naar Django aan het kijken hoe het zit qua (ontbrekende) deprecation messages. |
|
Het bleek toch te kloppen. In 1.8 zat de deprecation waarschuwing niet, maar in 1.11 wel. Dus... django heeft het prima gedaan. Wij hebben zelf niet opgelet :-) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In function
django.contrib.auth.__init__.authenticatethe signature of theauthenticatemethod of the various authentication backends is inspected. Django 2.1 silently skips backends that do not comply! Our custom SSOBackend is used across different versions of Django, so it is very important to have the signature right.