-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
check out math and maybe try changing initial values for ubermini_2.stan #12
Comments
@legault Hello! I'd like to roll this rock a little further down its path this week -- any updates on this? |
See commit e6fabd5 for a fix to the vcv function, sig2, and adding a prior to sigma_y. This addresses some of the modeling issues such that we now correctly infer the parameter values in ubermini_2.R The Cholesky decomp may no longer be necessary. |
@legault Thanks for this, but the issue wasn't about the vcv, are you sure it was wrong? Can you provide a little more details on what was wrong (and thus what you fixed here)? I'd like to understand and it's not so clear what errors you found in the math from your notes and the commit. |
I shouldn't have said "fix" as all I did was re-specify things using sigma instead variance (in vcv). Commit d85d59e has some additional changes, notably the addition of a function that sets initial values which avoid the numerical issues we've been seeing. |
@legault's commit mentioned above seems to have solved the initial conditions issue. Yay! |
A few more notes what happened here (from an email from @legault on 20 Nov 2020):
|
See ubermini_2.R. This relates also to this issue and and OSPREE issue 388 where we can NEVER get the model out of initial value issues. If much preferred you can play with code there (see ../phylogeny/compare_ospreedat_ubermini_2.R).
See 'Cholesky Factors of Covariance Matrices' in the Stan manual)
And one maybe or maybe not useful post from Stan Discourse:
"..it is not really a bug, just a numerical problem. You could also do init_r = some number less than the default of 2." here
@FaithJones to keep us cross-referenced!
The text was updated successfully, but these errors were encountered: