Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

loop_forever() -> loop() #2

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

felixsteghofer
Copy link

Hi again,

little fix to get the mqtt bridge running.

Best

@ljakob
Copy link
Owner

ljakob commented Dec 20, 2021

Hi,
could you please tell the motivation why to switch from loop_forever to loop? The code for the bridge was copied from a local project of mine that works for ages. The idea is to let the library call loop_forvever (with reconnect handling) and handle the automatic measurements in the overriden loop.
Cheers
Leif

@felixsteghofer
Copy link
Author

Hi, sry for the delay. Your library actually used loop so. I did not change anything semantically. Just to get the default mqtt example running :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants