-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: printing Var(27) and beyond overflowed ASCII #55
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I had wondered if someone would ever need that many variables to display, but I'm all for making this possible 😃; I left some suggestions and a question.
Co-authored-by: ljedrz <3750347+ljedrz@users.noreply.github.com>
Everything should be resolved now, except for the inverted comparison - I think it makes sense to view |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👌
For example, printing
Var(27)
spits out}
, because the character conversion function was basicallychar(96 + index)
, thereby overflowing the alphanumeric ASCII section. I've fixed this by encoding the lambda variables in a base 26 string.Any programs that print out lambda expressions with
Var(26)
or lower should remain unchanged in behavior.