Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: support key with starting brackets #202

Merged
merged 1 commit into from Mar 6, 2017

Conversation

dead-horse
Copy link
Contributor

@dead-horse dead-horse commented Mar 6, 2017

No description provided.

@dead-horse dead-horse changed the title fix: support key with starting brackts fix: support key with starting brackets Mar 6, 2017
@dead-horse
Copy link
Contributor Author

dead-horse commented Mar 6, 2017

merge #201 first and I'll rebase master and fix the test case in this branch?

ljharb
ljharb approved these changes Mar 6, 2017
Copy link
Owner

@ljharb ljharb left a comment

Thanks, I very much like that this is a minimal change with solely additive test changes.

Can you elaborate on this vs #201?

@ljharb
Copy link
Owner

ljharb commented Mar 6, 2017

Thanks, #201 is merged - rebase at will :-)

@dead-horse
Copy link
Contributor Author

dead-horse commented Mar 6, 2017

#201 fix qs.parse('a[b]=foo&a=toString') results to a: {b: 'foo'} instead of { a: { b: 'foo', toString: true } }.

#202 fix qs.parse('[=toString') results to {[: 'toString'} instead of {toString: true}

@dead-horse
Copy link
Contributor Author

dead-horse commented Mar 6, 2017

@dead-horse
Copy link
Contributor Author

dead-horse commented Mar 6, 2017

@ljharb rebased and fixed

@ljharb ljharb force-pushed the fix-starting-brackets branch from 4c8ae66 to 12152db Compare Mar 6, 2017
@ljharb
Copy link
Owner

ljharb commented Mar 6, 2017

Thanks!

@ljharb ljharb merged commit 12152db into ljharb:master Mar 6, 2017
1 check passed
@dead-horse dead-horse deleted the fix-starting-brackets branch Mar 6, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants