Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exclude unnecessary files from the npm package #356

Closed
wants to merge 1 commit into from

Conversation

pkuczynski
Copy link

Listed a few additional files and folders which are currently included in the published npm package, while they should not be.

Listed a few additional files and folders which are currently included in the published npm package, while they should not be.
Copy link
Owner

@ljharb ljharb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These are all necessary, and intentionally included. npm explore foo && npm install && npm test should always work.

@ljharb ljharb closed this Feb 25, 2020
@pkuczynski
Copy link
Author

Is .travis.yml (and few others) required too?

@ljharb
Copy link
Owner

ljharb commented Feb 25, 2020

As has been discussed on others of your PRs on other packages, that one could be excluded, but what’s the value in doing so for such a tiny file?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants