src: Remove ES5/6 shim dependencies #15
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This project is a pretty lightweight module and can be implemented as a zero dependency library. The actual implementation is basically 20 lines itself. Since this module already depends on ES5 & global.Promise I inlined the other 3 dependencies it has (all pretty trivial). This makes this module zero dependency which makes it really lightweight! The motiviation for this is to simplify `aws-sdk` ; Currently for aws-sdk; 50% of the transitive dependencies are the dependencies of `util.promisify` itself ( 24 ). This is quite a lot of weight.
Closed
ljharb
requested changes
Dec 19, 2019
| @@ -19,11 +19,21 @@ var slice = Function.call.bind(Array.prototype.slice); | |||
| var concat = Function.call.bind(Array.prototype.concat); | |||
| var forEach = Function.call.bind(Array.prototype.forEach); | |||
|
|
|||
| var hasSymbols = require('has-symbols')(); | |||
| var hasSymbols = typeof global.Symbol !== 'function'; | |||
There was a problem hiding this comment.
this will cause it to pass on a symbol sham; the intention is to only have it be true for native symbols. (also, you inverted the logic, breaking it)
Suggested change
| var hasSymbols = typeof global.Symbol !== 'function'; | |
| var hasSymbols = typeof Symbol === 'function' && typeof Symbol() === 'symbol'; |
|
|
||
| var kCustomPromisifiedSymbol = hasSymbols ? Symbol('util.promisify.custom') : null; | ||
| var kCustomPromisifyArgsSymbol = hasSymbols ? Symbol('customPromisifyArgs') : null; | ||
|
|
||
| var getOwnPropertyDescriptors = function _getOwnPropertyDescriptors(obj) { | ||
| var out = {}; | ||
| var keys = Object.keys(obj); |
There was a problem hiding this comment.
this means the implementation is reliant on nobody doing delete Object.keys
|
Willfix. |
|
I just pushed up baa0cf6 which uses es-abstract's |
|
That dependency has more transitive deps then the ones I am removing. I don't think there's any point left. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This project is a pretty lightweight module and can be implemented
as a zero dependency library.
The actual implementation is basically 20 lines itself.
Since this module already depends on ES5 & global.Promise I
inlined the other 3 dependencies it has (all pretty trivial).
This makes this module zero dependency which makes it really
lightweight!
The motiviation for this is to simplify
aws-sdk;Currently for aws-sdk; 50% of the transitive dependencies are
the dependencies of
util.promisifyitself ( 24 ). This isquite a lot of weight.
Fixes #14