Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Beacon oscillator #40

Merged
merged 1 commit into from
Apr 19, 2020
Merged

Add Beacon oscillator #40

merged 1 commit into from
Apr 19, 2020

Conversation

theodumont
Copy link
Contributor

Please let me know is everything is ok!

@codecov
Copy link

codecov bot commented Apr 18, 2020

Codecov Report

Merging #40 into master will increase coverage by 0.07%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #40      +/-   ##
==========================================
+ Coverage   97.68%   97.76%   +0.07%     
==========================================
  Files          12       12              
  Lines         259      268       +9     
==========================================
+ Hits          253      262       +9     
  Misses          6        6              
Impacted Files Coverage Δ
seagull/lifeforms/__init__.py 100.00% <100.00%> (ø)
seagull/lifeforms/oscillators.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 61c2859...ab328b0. Read the comment docs.

@ljvmiranda921 ljvmiranda921 self-requested a review April 19, 2020 00:14
Copy link
Owner

@ljvmiranda921 ljvmiranda921 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks so much and congrats to your first contribution in Seagull! Hope to see you again soon :)

@ljvmiranda921 ljvmiranda921 merged commit 8bad223 into ljvmiranda921:master Apr 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants