Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add CF convention metadata to variables #113

Merged
merged 8 commits into from
Feb 6, 2023

Conversation

jmcvey3
Copy link
Collaborator

@jmcvey3 jmcvey3 commented Jan 31, 2023

PR to add metadata to dolfyn-created variables. Update for #102

@coveralls
Copy link

coveralls commented Jan 31, 2023

Pull Request Test Coverage Report for Build 4059134169

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 192 of 203 (94.58%) changed or added relevant lines in 16 files are covered.
  • 214 unchanged lines in 11 files lost coverage.
  • Overall coverage decreased (-0.01%) to 89.906%

Changes Missing Coverage Covered Lines Changed/Added Lines %
dolfyn/adv/motion.py 5 6 83.33%
dolfyn/io/nortek2_defs.py 35 36 97.22%
dolfyn/io/rdi.py 11 12 91.67%
dolfyn/adv/turbulence.py 9 11 81.82%
dolfyn/io/api.py 14 16 87.5%
dolfyn/io/nortek.py 23 27 85.19%
Files with Coverage Reduction New Missed Lines %
dolfyn/io/base.py 2 93.13%
dolfyn/rotate/rdi.py 2 96.83%
dolfyn/adv/turbulence.py 3 94.87%
dolfyn/velocity.py 4 93.98%
dolfyn/adp/clean.py 5 94.87%
dolfyn/io/nortek2_defs.py 6 95.93%
dolfyn/rotate/base.py 8 92.08%
dolfyn/rotate/vector.py 11 90.68%
dolfyn/io/nortek2.py 19 91.57%
dolfyn/io/nortek.py 46 90.25%
Totals Coverage Status
Change from base Build 4008776229: -0.01%
Covered Lines: 5077
Relevant Lines: 5647

💛 - Coveralls

@jmcvey3 jmcvey3 merged commit 088ff77 into lkilcher:master Feb 6, 2023
@jmcvey3 jmcvey3 deleted the cf_conventions branch February 6, 2023 20:37
@jmcvey3 jmcvey3 mentioned this pull request Feb 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants