Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ADCP clean surface bugfix #99

Merged
merged 7 commits into from
Apr 22, 2022
Merged

Conversation

jmcvey3
Copy link
Collaborator

@jmcvey3 jmcvey3 commented Apr 22, 2022

  • Need to add test

@coveralls
Copy link

coveralls commented Apr 22, 2022

Pull Request Test Coverage Report for Build 2208606626

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 10 of 13 (76.92%) changed or added relevant lines in 2 files are covered.
  • 5 unchanged lines in 1 file lost coverage.
  • Overall coverage increased (+0.04%) to 90.723%

Changes Missing Coverage Covered Lines Changed/Added Lines %
dolfyn/adp/clean.py 5 6 83.33%
dolfyn/tests/test_clean.py 5 7 71.43%
Files with Coverage Reduction New Missed Lines %
dolfyn/tests/test_clean.py 5 80.82%
Totals Coverage Status
Change from base Build 2204964271: 0.04%
Covered Lines: 4645
Relevant Lines: 5120

💛 - Coveralls

@jmcvey3 jmcvey3 merged commit b4aa54f into lkilcher:master Apr 22, 2022
@jmcvey3 jmcvey3 deleted the clean_range_bug branch April 22, 2022 16:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants