Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to 2.4.1 #4

Open
wants to merge 7 commits into
base: master
Choose a base branch
from
Open

Upgrade to 2.4.1 #4

wants to merge 7 commits into from

Conversation

duhast
Copy link

@duhast duhast commented Oct 25, 2014

  • use fancytree v. 2.4.1
  • stylesheets converted to SCSS and does not use ERB anymore
  • minimized and concatenated file versions removed in favor of asset pipeline
  • skins are working

@lksv
Copy link
Owner

lksv commented Oct 30, 2014

Thanks for your work.

I was used to update to a new version of fancytree by rake fancytree:update task. This stops to work with your change in app/assets/javascripts/fancytree/jquery.fancytree-all.js. I prefer to use this orginal file the same as fancytree's dist directory (e.g. the file which is officially provided by fancytree). I am not against sass. That's good idea. But could you please change the pull request to:

  • keep orginal app/assets/javascripts/fancytree/jquery.fancytree-all.js
  • keep rake fancytree:update working

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants