Skip to content
This repository has been archived by the owner on Jan 22, 2020. It is now read-only.

Category marks video as game #103

Open
GeorgeAnton1 opened this issue May 28, 2016 · 7 comments
Open

Category marks video as game #103

GeorgeAnton1 opened this issue May 28, 2016 · 7 comments

Comments

@GeorgeAnton1
Copy link

There seems to be some occurrence (possibly all) where the category says that a video is a game.
I only tested this with Luigis mansion (eu).

@llakssz
Copy link
Owner

llakssz commented May 28, 2016

Yes, some titles are E3 promo videos.
In my own implementation of the json creator I ignored these but since we do not control the json file anymore, we will have to ignore them on the fly.
It is safe to ignore titles that contain " E3 " 👍

@GeorgeAnton1
Copy link
Author

Why don't you control the json creator?

@noirscape
Copy link

noirscape commented May 28, 2016

The guy behind the titlekey site is the one who manages the file. cearp
used to manage it, but the guy behind the titlekey site found out how the
format worked, and since then he is the one that manages the file because
it is automated on that site (cearp had to manually generate it each time).

On 28 May 2016 at 12:50, GeorgeAnton1 notifications@github.com wrote:

Why don't you control the json creator?


You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
#103 (comment),
or mute the thread
https://github.com/notifications/unsubscribe/AMz6qe3YqFxR17zw8CVB5sugo4CahahSks5qGB4FgaJpZM4Io9u1
.

@DrakiaXYZ
Copy link
Collaborator

As ev1l0rd said, it's mostly convenience. The titlekey database site created a JSON format almost exactly the same as ours, so it was just easier to use that than continue to create our own and find somewhere to host it/link to it.

@cerea1killer
Copy link

Exactly. And this way users don't have to find the latest wings.json
themselves. That was the big push why we changed that

On Sat, May 28, 2016, 11:24 AM Steven Scott notifications@github.com
wrote:

As ev1l0rd said, it's mostly convenience. The titlekey database site
created a JSON format almost exactly the same as ours, so it was just
easier to use that than continue to create our own and find somewhere to
host it/link to it.


You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
#103 (comment),
or mute the thread
https://github.com/notifications/unsubscribe/ASSNTXcmEuzXPHgyLE69zAOsoDwatPbUks5qGIhagaJpZM4Io9u1
.

@GeorgeAnton1
Copy link
Author

Oh right, I didn't realise it was coming straight from that title key site.
Would ignoring the videos on the fly be a possibility?

@llakssz
Copy link
Owner

llakssz commented May 29, 2016

Sure it's possible, easy in fact :)
We already skip some stuff, like system title, etc, this would just be another thing to skip.
Everything that contains " E3 " is just a promo video, there are some videos that don't obey to this, but this gets many of them.
'Picross e3' would not be skipped because " E3 " would not find it 👍

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants