Fixes crashes in development mode #2
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
P.S. @llaske I'm participating in GSoC'19 and I want to discuss my ideas regarding Sugarizer, Exerciser, and other activities. |
llaske
reviewed
Mar 6, 2019
src/containers/Builders/Template.js
Outdated
| @@ -10,7 +10,7 @@ import { | |||
| CHOOSE, | |||
| CLOZE_TEXT, | |||
| MCQ, | |||
| REORDER_LIST, TITLE_OF_EXERCISE | |||
There was a problem hiding this comment.
Guess this change is not related to this issue
llaske
reviewed
Mar 6, 2019
src/containers/Scores/Scores.js
Outdated
| @@ -1,8 +1,7 @@ | |||
| import React, {Component} from "react" | |||
| import {Bar, Line, Pie} from 'react-chartjs-2'; | |||
There was a problem hiding this comment.
Guess this change is not related to this issue
llaske
reviewed
Mar 6, 2019
src/containers/Scores/Scores.js
Outdated
| import {withRouter} from "react-router-dom"; | ||
| import {connect} from "react-redux"; | ||
| import {addScore} from "../../store/actions/exercises"; |
There was a problem hiding this comment.
Guess this change is not related to this issue
|
Not a bad idea to solve this issue to allow work in dev mode. Could you reopen the issue on this repo to reference it here? Plus, your PR include code update not related to this fix (see my comments). Could you clean it? |
|
Okay thanks. Will review your suggestions. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes issue #6. The color value was not handled properly which was causing the react app to throw an error that cannot read property of undefined. According to the original developer, this app is not expected to function properly in development mode due to dependence on Sugarizer and Sugarizer Neighborhood data but I still think that result screen is a crucial functionality of the app and it should not break at the result screen even at the development mode.