Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implode Activity: fix Warning message button alignment #1025

Closed
Shreyas-SAS opened this issue Mar 21, 2022 · 3 comments
Closed

Implode Activity: fix Warning message button alignment #1025

Shreyas-SAS opened this issue Mar 21, 2022 · 3 comments
Labels
enhancement to be release Fixed, to be release
Milestone
v1.7

Comments

@Shreyas-SAS
Copy link
Contributor

Proposed:
Currently the warning message that comes up in implode activity when there are no possible moves left has a continue button that is left aligned on larger screens and behaves well on smaller ones.
I would like to center the text Continue so that the button looks much more formal and not like a bug.

It is a small change but I feel that it makes a large visual difference as misalignment is easily noticeable.

Current:
image

proposed:
image
Shreyas-SAS added a commit to Shreyas-SAS/sugarizer that referenced this issue Mar 21, 2022
@Shreyas-SAS
Fixed issue llaske#1025: Implode: Warning msg
5795f3c
@Shreyas-SAS Shreyas-SAS mentioned this issue Mar 21, 2022
Merged
@llaske llaske changed the title Implode Activity: fix Warning message button Implode Activity: fix Warning message button alignment Mar 23, 2022
@llaske
Copy link
Owner

llaske commented Mar 23, 2022

Fixed in #1026

@llaske llaske added the to be release Fixed, to be release label Mar 23, 2022
@AnandChourasia007
Copy link
Contributor

Hey @Shreyas-SAS , you are not supposed to close solved issue with 'to be release' label before release of the next version of sugarizer.

@Shreyas-SAS
Copy link
Contributor Author

Hey @Shreyas-SAS , you are not supposed to close solved issue with 'to be release' label before release of the next version of sugarizer.

Oh is it. Sorry it just slipped off my mind. Thanks. I will repen it.

@Shreyas-SAS Shreyas-SAS reopened this Apr 8, 2022
@llaske llaske added this to the v1.7 milestone Mar 28, 2023
@llaske llaske closed this as completed Mar 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement to be release Fixed, to be release
Projects
None yet
Milestone
v1.7
Development

No branches or pull requests
3 participants
@llaske @AnandChourasia007 @Shreyas-SAS