Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Save Clock activity settings in Journal #204

Closed
llaske opened this issue Apr 18, 2018 · 2 comments
Closed

Save Clock activity settings in Journal #204

llaske opened this issue Apr 18, 2018 · 2 comments
Labels
enhancement
Milestone
v1.1

Comments

@llaske
Copy link
Owner

llaske commented Apr 18, 2018

Clock activity settings (clock format and display type) is not saved in the Journal.
It could be nice to save it into the journal so the display could be the same next time the activity will be open.
@llaske
Copy link
Owner Author

llaske commented Oct 21, 2018

Clock activity source code is here: https://github.com/llaske/sugarizer/tree/dev/activities/Clock.activity
Adding datastore handling to an existing activity is explain here: https://github.com/llaske/sugarizer/blob/dev/docs/tutorial_step4.md

@llaske llaske mentioned this issue Nov 6, 2018
Merged
@llaske llaske modified the milestone: v1.1 Nov 6, 2018
llaske added a commit that referenced this issue Nov 13, 2018
@llaske
Merge pull request #235 from sdziuda/patch-2
9db543c 
Save Clock activity settings in Journal (fixes issue #204)
@llaske llaske added this to the v1.1 milestone Nov 13, 2018
@llaske
Copy link
Owner Author

llaske commented Nov 13, 2018

Fixed in 9db543c

@llaske llaske closed this as completed Jan 21, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
v1.1
Development

No branches or pull requests
1 participant
@llaske