Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Resize function gives error in TankOp Activity #549

Closed
s-mag opened this issue Jan 3, 2020 · 4 comments
Closed

Resize function gives error in TankOp Activity #549

s-mag opened this issue Jan 3, 2020 · 4 comments
Labels
bug to be release Fixed, to be release
Milestone
v1.3

Comments

@s-mag
Copy link
Contributor

s-mag commented Jan 3, 2020 •
edited
Loading

I guess there is a bug in the code of play.js file.
It is due to the last commit with respect to the issue #404 .
Error comes in an infinite loop.
Error

The error arises after we change modes of the game and the game stops working.
ezgif com-video-to-gif (1)

@llaske Can you replicate this Issue?
@s-mag
Copy link
Contributor Author

s-mag commented Jan 3, 2020

Due this issue I was not able to resize screen while fixing issue #547
I am working on it...

@llaske llaske added the bug label Jan 3, 2020
@llaske
Copy link
Owner

llaske commented Jan 3, 2020

Hmmm. You're right.

@s-mag s-mag mentioned this issue Jan 3, 2020
Merged
@sarthak-g sarthak-g mentioned this issue Jan 4, 2020
Merged
@sarthak-g
Copy link
Contributor

@s-mag thanks for raising this issue.
Fixed this issue in pull request #552

@s-mag s-mag mentioned this issue Jan 4, 2020
Closed
llaske added a commit that referenced this issue Jan 5, 2020
@llaske
Merge pull request #552 from sarthak-g/sarthak-sugarizer
a58c747 
solved issue #549(resize function error)
@llaske
Copy link
Owner

llaske commented Jan 5, 2020

Fixed in #552

@llaske llaske added the to be release Fixed, to be release label Jan 5, 2020
@llaske llaske changed the title resize function gives error in TankOp Activity. Resize function gives error in TankOp Activity Jan 18, 2020
@llaske llaske added this to the v1.3 milestone Mar 11, 2020
@llaske llaske closed this as completed Mar 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug to be release Fixed, to be release
Projects
None yet
Milestone
v1.3
Development

No branches or pull requests
3 participants
@llaske @sarthak-g @s-mag