Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LabyrinthJS: Idea selection-indicator while linking ideas #1584

Merged
merged 1 commit into from
Apr 15, 2024

Conversation

44yu5h
Copy link

@44yu5h 44yu5h commented Apr 5, 2024

While linking ideas, no selection-indicator of selected idea was visible thereby creating confusion. Added a selection-indicator to the currently selected idea and auto-deselect after making a link.

@44yu5h 44yu5h changed the title add undo/redo shortcut and idea selection pointer to LabyrinthJS add undo/redo shortcut and idea selection-indicator to LabyrinthJS Apr 5, 2024
@VishnuVardhanBR
Copy link
Contributor

Please avoid sending a PR before creating an issue which should also be reviewed by @llaske.

@44yu5h
Copy link
Author

44yu5h commented Apr 5, 2024

@VishnuVardhanBR It is a minor UI/UX impovement. I don't think this needs an issue to be created. We can discuss here if there's anything to. But I'm new to this community, if that's what people follow here then I shall do so :)

@llaske
Copy link
Owner

llaske commented Apr 6, 2024

Keyboard shortcuts are useless in Sugarizer because it's too complex for children and because Sugarizer is mostly use on tablets.
As @VishnuVardhanBR suggest, please open an issue before sending a PR.

While linking ideas, no selection-indicator of selected idea was visible thereby creating confusion.
Added a selection-indicator to the currently selected idea and auto-deselect after making a link.

Signed-off-by: Aayush Raj <meet44yu5h@gmail.com>
@44yu5h
Copy link
Author

44yu5h commented Apr 6, 2024

@llaske Removed shortcuts. Thanks.

Issue #1585

@44yu5h 44yu5h changed the title add undo/redo shortcut and idea selection-indicator to LabyrinthJS to LabyrinthJS: Idea selection-indicator while linking ideas Apr 7, 2024
@44yu5h 44yu5h changed the title to LabyrinthJS: Idea selection-indicator while linking ideas LabyrinthJS: Idea selection-indicator while linking ideas Apr 7, 2024
@llaske llaske merged commit f93a713 into llaske:dev Apr 15, 2024
@llaske
Copy link
Owner

llaske commented Apr 15, 2024

Nice. Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants