Fix filename sanitation #22
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
llllllllll
reviewed
Aug 10, 2017
slider/library.py
Outdated
| @@ -53,7 +53,7 @@ def keys(self): | |||
| if sys.platform.startswith('win'): | |||
| def sanitize_filename(name): | |||
| for invalid_character in r':*?"\/|<>[]': | |||
| name.replace(invalid_character, '') | |||
There was a problem hiding this comment.
That will do it. One other thing is that we are stripping too many characters, should we remove the ones that are not actually invalid?
There was a problem hiding this comment.
i'd prefer not to strip characters that aren't the invalid ones
There was a problem hiding this comment.
sorry, I totally agree. Some of the characters in the string are in fact valid for windows based on the original screen shot.
|
Thank you very much! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.