Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GPU compute mode option #80

Closed
pelesh opened this issue Sep 3, 2020 · 1 comment
Closed

GPU compute mode option #80

pelesh opened this issue Sep 3, 2020 · 1 comment

Comments

@pelesh
Copy link
Collaborator

pelesh commented Sep 3, 2020

It would be good to add "gpu" as a "compute_mode" option in HiOp. However, this option is not independent of "mem_space" selection. Here is the summary of compute mode and memory space option compatibilities:

  1. "cpu" option works only with "default", "host" and likely "um" memory space options.
  2. "hybrid" works with all but "device" memory space option.
  3. "gpu", if added, would work with "um", "pinned" or "device" options.

We can simply document this and expect user to select a meaningful combination or we can add some logic to HiOp options class that would warn user or when incompatible combination was selected and fall back to the next best thing.

If HiOp is built without RAJA support, only "default" memory space is available.

Options "um", "pinned" or "device" are available only if HiOp is built with GPU support (for now it's CUDA only) turned on.

CC @ashermancinelli @cnpetra

@cnpetra
Copy link
Collaborator

cnpetra commented Oct 9, 2020

warn user or when incompatible combination was selected and fall back to the next best thing

this can/should be done in

void hiopOptions::ensureConsistence()

@cnpetra cnpetra closed this as completed Oct 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants