Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix/valueenum scaladoc #129

Merged
merged 10 commits into from
Mar 18, 2017
Merged

Fix/valueenum scaladoc #129

merged 10 commits into from
Mar 18, 2017

Conversation

lloydmeta
Copy link
Owner

No description provided.

@lloydmeta
Add a repro in macro test
8c13c43
@lloydmeta
Fix #128
a05e3bf 
In documentation mode, the trees found are ModuleDefs instead of Templates,
possibly because comments are not parsed away.

Maybe we can move this filter upwards to the find trees by type part...
@lloydmeta
Make Travis build docs for test
4714c06
@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling 4714c06 on fix/valueenum-scaladoc into e89ae9d on master.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling 30c23e9 on fix/valueenum-scaladoc into e89ae9d on master.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling 68d5dca on fix/valueenum-scaladoc into e89ae9d on master.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling 24e93ec on fix/valueenum-scaladoc into e89ae9d on master.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling b51ccfa on fix/valueenum-scaladoc into e89ae9d on master.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling b51ccfa on fix/valueenum-scaladoc into e89ae9d on master.

@lloydmeta
Make subclass search return ModuleDefs instead of Trees
993fe00 
Allows us to use the more specific ModuleDef API if needed.
We *should* be only dealing with ModuleDefs anyway given the filter
(filter is used instead of collect because for simplicity we have
a chained inheritance check)
@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling 993fe00 on fix/valueenum-scaladoc into e89ae9d on master.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling cc24894 on fix/valueenum-scaladoc into e89ae9d on master.

@lloydmeta lloydmeta merged commit ad2471c into master Mar 18, 2017
@lloydmeta lloydmeta deleted the fix/valueenum-scaladoc branch March 18, 2017 09:28
@lloydmeta lloydmeta mentioned this pull request Mar 18, 2017
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lloydmeta @coveralls