Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Scala 2.13.0 #234

Merged
merged 3 commits into from
Jun 12, 2019
Merged

Scala 2.13.0 #234

merged 3 commits into from
Jun 12, 2019

Conversation

joan38
Copy link
Contributor

@joan38 joan38 commented Jun 7, 2019

No description provided.

@coveralls
Copy link

coveralls commented Jun 7, 2019

Coverage Status

Coverage remained the same at 91.313% when pulling 9295305 on joan38:master into a846b2f on lloydmeta:master.

@joan38 joan38 force-pushed the master branch 3 times, most recently from 7ccca2b to d89c206 Compare June 7, 2019 20:31
Copy link
Owner

@lloydmeta lloydmeta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are a number of unresolved dependencies that you need to resolve for 2.13. I'd start by ++2.13.0 in the macros-aggregate project and seeing whether there's a scalatest (test:compile) that can be used, then work up to core-aggregate.

Then you'll need to look at each of the projects in scala213ProjectRefs (in build.sbt) and either bump versions or remove the ones that don't have 2.13 artefacts published yet.

EDIT: for reference, there's the 2.13 job on Travis, e.g. https://travis-ci.org/lloydmeta/enumeratum/jobs/542947134

@lloydmeta
Copy link
Owner

Yep, looks like we'll need this to even begin :) scalatest/scalatest#1601

This is the list I was talking about earlier.

enumeratum/build.sbt

Lines 100 to 109 in b6d98ed

lazy val scala213ProjectRefs = Seq(
enumeratumJson4s,
enumeratumScalacheckJvm,
enumeratumScalacheckJs,
enumeratumPlayJsonJvm,
enumeratumPlayJsonJs,
enumeratumArgonautJs,
enumeratumArgonautJvm,
enumeratumPlay
).map(Project.projectToRef)

For now, it looks like Argonaut has 2.13 artefacts on Maven Central, but not the others ?

@joan38
Copy link
Contributor Author

joan38 commented Jun 10, 2019

I pushed with scalatest_2.13 3.0.8
It's complaining for enumeratum_2.13 itself not published in the tests

@lloydmeta
Copy link
Owner

lloydmeta commented Jun 11, 2019

I think it's mostly a matter of making the versions in the build match with what each project needs, but I went ahead and pre-published the 2.13 arefacts for macro, core and test so the tests now pass, mostly.

All that needs to be done is to comment out the references here that don't have 2.13 artefacts:

enumeratum/build.sbt

Lines 100 to 109 in b6d98ed

lazy val scala213ProjectRefs = Seq(
enumeratumJson4s,
enumeratumScalacheckJvm,
enumeratumScalacheckJs,
enumeratumPlayJsonJvm,
enumeratumPlayJsonJs,
enumeratumArgonautJs,
enumeratumArgonautJvm,
enumeratumPlay
).map(Project.projectToRef)

I think it should just be the Play related ones.

lloydmeta and others added 2 commits June 12, 2019 20:44
Copy link
Owner

@lloydmeta lloydmeta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, will save merging until tmw when I have more time.

@lloydmeta lloydmeta merged commit ee1b3d1 into lloydmeta:master Jun 12, 2019
@lloydmeta
Copy link
Owner

Thanks @joan38, just released all artefacts :)

@joan38
Copy link
Contributor Author

joan38 commented Jun 13, 2019

Thanks @lloydmeta

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants