-
Notifications
You must be signed in to change notification settings - Fork 149
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Scala 2.13.0 #234
Scala 2.13.0 #234
Conversation
7ccca2b
to
d89c206
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There are a number of unresolved dependencies that you need to resolve for 2.13. I'd start by ++2.13.0
in the macros-aggregate
project and seeing whether there's a scalatest
(test:compile
) that can be used, then work up to core-aggregate
.
Then you'll need to look at each of the projects in scala213ProjectRefs
(in build.sbt
) and either bump versions or remove the ones that don't have 2.13
artefacts published yet.
EDIT: for reference, there's the 2.13
job on Travis, e.g. https://travis-ci.org/lloydmeta/enumeratum/jobs/542947134
Yep, looks like we'll need this to even begin :) scalatest/scalatest#1601 This is the list I was talking about earlier. Lines 100 to 109 in b6d98ed
For now, it looks like Argonaut has |
I pushed with scalatest_2.13 |
I think it's mostly a matter of making the versions in the build match with what each project needs, but I went ahead and pre-published the 2.13 arefacts for macro, core and test so the tests now pass, mostly. All that needs to be done is to comment out the references here that don't have 2.13 artefacts: Lines 100 to 109 in b6d98ed
I think it should just be the Play related ones. |
Signed-off-by: lloydmeta <lloydmeta@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, will save merging until tmw when I have more time.
Thanks @joan38, just released all artefacts :) |
Thanks @lloydmeta |
No description provided.