Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds Play 2.8.x support, drops Scala 2.10 support #269

Merged
merged 8 commits into from
Jan 18, 2020

Conversation

a1kemist
Copy link
Contributor

In play-json 2.8.x, the writes trait was changed from Writes[-T] (contravariant) to Writes[T] (invariant) which breaks enumeratum's PlayJsonEnum trait. This PR does the following:

  • Adds an implicit helper to contraMap the Writes provided by the existing trait. This seems to be sufficient enough to support play-json 2.8.x without any more complicated code changes.
  • Drops Scala 2.10 support. While working on this PR there were a few sporadic dependency resolution issues with resolving 2.10 based dependencies, but now I'm unable to resolve any of the 2.10 dependencies when building the project, so I've elected to drop 2.10 support with this PR.
  • Cleans up build.sbt now that it seems like Scala 2.13 is supported on all projects.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.02%) to 90.726% when pulling f29cc93 on a1kemist:play-2.8-support into 9c41215 on lloydmeta:master.

Copy link
Owner

@lloydmeta lloydmeta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❤️ the cleanup in the build, thanks !

Also +1 to dropping 2.10 support at this point :)

Going to merge this tmw when I am back.

@lloydmeta lloydmeta merged commit 19ff399 into lloydmeta:master Jan 18, 2020
@lloydmeta
Copy link
Owner

Thanks for this @a1kemist, and apologies for releasing later than I said. Just merged, and pushed a new release. It should be up on Maven Central in a bit.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants