reactivemongo: Only depend on the bson-api, noshaded variant #270
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There is no need to pull in reactivemongo, the driver, since all we are concerned with is the BSON API. Also, starting with version 0.19.6, there are now two variants, a noshaded version and a version which has Netty integrated into it for projects using Netty themselves avoiding incompatibilities. Since we do not know in advance which library is choosen in a project, make the dependency a "provided" one.
lloydmeta
approved these changes
Feb 12, 2020
|
Scratch that; currently on holiday and didn't bring the right laptop for publishing; will do when I get back. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is no need to pull in reactivemongo, the driver, since all we are
concerned with is the BSON API.
Also, starting with version 0.19.6, there are now two variants, a noshaded
version and a version which has Netty integrated into it for projects using
Netty themselves avoiding incompatibilities.
Since we do not know in advance which library is choosen in a project, make the
dependency a "provided" one.