-
Notifications
You must be signed in to change notification settings - Fork 149
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/value enums #29
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
lloydmeta
commented
Apr 14, 2016
- Adds ValueEnums (and associated integrations with Play, PlayJson, and UPickle)
- Currently fairly tightly constrained to work with just Long, Int, and Short
- Add an integration with Circe.
- Refactor a bunch of test code to be more DRY - Extend PlayValueEnums with their respective Json helpers - Add tests for PlayValueEnums
- Upgrade Scalatest and ScalaJS - Add ValueEnum UPicklers with tests - Add a PartialFunction enricher - Refactor some older code
# The first commit's message is: Add more to the readme # This is the 2nd commit message: More # This is the 3rd commit message: Fix links # This is the 4th commit message: Moar readme # This is the 5th commit message: Add to readme # This is the 6th commit message: fix readme code
- Add TOC - More details, examples, explanations
lloydmeta
force-pushed
the
feature/value-enums
branch
from
April 14, 2016 17:19
dc2b78f
to
8fdf076
Compare
- Add comments/scaladocs
…not using consecutive elements - Small optimisation in Macro
- Add note to mention the above - Bump Circe version
lloydmeta
force-pushed
the
feature/value-enums
branch
from
April 15, 2016 16:57
5b122c6
to
66e6afa
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.