[Breaking] MOS: 65816 assembler fixes, part 2 #456
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5 tasks
asiekierka
commented
Mar 10, 2024
| ; CHECK: R_MOS_ADDR16 .text+0x1 | ||
| lda !addr16 ; CHECK: ad 00 00 | ||
| ; CHECK: R_MOS_ADDR16 .text+0x202 | ||
| ; TODO: lda addr16 |
There was a problem hiding this comment.
We currently lack a 16-bit equivalent to .zeropage. I've left these for a later PR.
asiekierka
commented
Mar 10, 2024
| lda #^addr24 ; CHECK: a9 00 | ||
| ; CHECK: R_MOS_ADDR24_BANK .text+0x30303 | ||
|
|
||
| ; TODO: Immediate (16-bit) |
There was a problem hiding this comment.
We currently lack a way to appropriately tell the assembler to force 16-bit immediates, without using mos16(). I've left these for a later PR.
mysterymath
changed the title
|
After merging the previous change, it looks like this branch has conflicts now and needs to be synced. |
- The immediate and address modifiers (#<, #>, #^, <, !, >) now adhere to
WDC recommendations as documented in the 65816 datasheet.
- In particular, this means the behaviour of "lda >addr" changes, while
"lda !addr" and "lda #^addr" have been introduced.
- Immediate expressions now emit R_MOS_IMM8 and R_MOS_IMM16, while address
expressions now emit R_MOS_ADDR8 and R_MOS_ADDR16 relocations.
- Some error messages have been adjusted to more accurately represent the
assembler's limitations.
- Bugs in the SPC700's handling of "addr + X" and "addr + Y" addressing mode
syntaxes have been fixed.
- Extensive tests have been added to test for addressing mode and modifier
handling.
Note that this includes breaking changes for the following expressions:
- "lda >addr" was previously interpreted as "lda mos16hi(addr)", but now will
be interpreted as "lda mos24(addr)". This is unlikely to break production
code.
- "lda <addr8" was previously interpreted as "lda mos16lo(addr)", but now will
be interpreted as "lda mos8(addr)". As the two relocations are functionally
(but not semantically) equivalent, this should not break production code.
- Likewise, functional (but not semantic) changes involve the relocations
emitted by immediate expressions ("lda #val").
This matches WDC 65816 and 65EL02 recommendations, respectively.
asiekierka
force-pushed
the
upstream/pr/assembler-65816-2
branch
from
8fe7435
to
abb9201
Compare
|
Ah, sorry; should be fixed now. |
mysterymath
approved these changes
Mar 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
More fixes for #454 . These come after #455 .
Note that this includes breaking changes for the following expressions: