[CHIRRTL] Use InnerSymbolOpInterface on cmem and smem. #4874
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add tests checking verification happens for these, as proxy for checking support for code looking for InnerSymbolOpInterface's. Add test for behavior of conservatively not checking per-field symbols if operation's result type doesn't implement FieldIDTTypeInterface.
…test. Ops implementing InnerSymbol are now required to clarify whether they support per-field symbols and what result is named by symbols. CHIRRTL memory ops do not support per-field and no result is named.
dtzSiFive
force-pushed
the
fix/chirrtl-innersym
branch
from
f1f31b3
to
dc12854
Compare
|
Updated now that InnerSymbol requires operations to specify whether per-field symbols are supported and what result is named by a symbols on the op, dropping test enshrining "trust" ("punt") behavior and tweaking tests for new error messages and demonstrating verification works. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add tests checking verification happens for these, as proxy for checking support for code looking for InnerSymbolOpInterface's.
Add test for behavior of conservatively not checking per-field symbols if operation's result type doesn't implement FieldIDTTypeInterface.