Update RationaleFIRRTL.md #4911
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The "symbol rationale" document link is broken since the file was moved/removed at some point. This change is just to punt and remove the bad link, but perhaps a minor revision would be better.
|
Thanks! This might be the best we can do for now, indeed. FWIW lots of relative links are broken, including our diagrams 😢 . See #4343 and linked issues. It would be swell to fix whatever builds/deploys/arranges this to have this all work again . This, however, is wrong on website AND when viewed from GitHub, indeed it just points to wrong place and wasn't updated I think, as you say. Makes sense to drop for now, hopefully linking to that issue will help remind us to restore it should we fix how that works. |
|
Status? |
|
Sure, works for me. No link is better than dead link. Thanks! |
dtzSiFive
reviewed
May 1, 2023
The document still exists. The link is just broken. Rewording.
|
Thanks for fixing this! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The "symbol rationale" document link is broken since the file was moved/removed at some point.
This change is just to punt and remove the bad link, but perhaps a minor revision would be better.