[Arc] Memory ops: optional enables and folders #4976
Merged
+234
−56
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
uenoku
reviewed
Apr 10, 2023
Make the enables of the MemoryReadPortOp, MemoryWritePortOp, and MemoryWriteOp optional. Its absence means a constant true enable. Add folders to remove the operand when it is constant true as well as remove the entire operation when the enable is constant false as the writes do not ever happen in this case and the read returns an undefined value.
maerhart
force-pushed
the
dev/maerhart/arc-optional-memory-enable
branch
from
eda66d7
to
0205a22
Compare
fabianschuiki
approved these changes
Apr 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make the enables of the MemoryReadPortOp, MemoryWritePortOp, and MemoryWriteOp optional. Its absence means a constant true enable. Add folders to remove the operand when it is constant true as well as remove the entire operation when the enable is constant false as the writes do not ever happen in this case and the read returns an undefined value.