[Seq] Lower FirMemOp to HWModuleGeneratedOp #5024
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fabianschuiki
added
FIRRTL
fabianschuiki
force-pushed
the
fschuiki/lower-firmem
branch
from
a1c211c
to
f9d9a39
Compare
fabianschuiki
force-pushed
the
fschuiki/seq-firmem
branch
from
072ebcc
to
f996afa
Compare
fabianschuiki
force-pushed
the
fschuiki/lower-firmem
branch
from
f9d9a39
to
ba81672
Compare
fabianschuiki
force-pushed
the
fschuiki/seq-firmem
branch
from
f996afa
to
f6d12b4
Compare
fabianschuiki
force-pushed
the
fschuiki/lower-firmem
branch
from
ba81672
to
f26c703
Compare
fabianschuiki
force-pushed
the
fschuiki/lower-firmem
branch
3 times, most recently
from
c1120f5
to
5c04613
Compare
Add the `LowerFirMem` pass which lowers `seq.firmem` ops to a corresponding `hw.module.generated` op. The pass intends to reflect what `LowerToHW` does in `lowerMemoryDecls`: it collects a list of memory ops in the design, distills them down into memory parameters, deduplicates those parameters, creates one `hw.module.generated` op for each unique memory config, and replaces the memory ops with instances of this generated module. The `LowerFirMem` pass is intended as an intermediate solution to allow `seq.firmem` to be lowered through `HWMemSimImpl` without changing the latter's implementation. Existing tools that have passes operating on `hw.module.generated`-style memories can simply run the `LowerFirMem` pass and have the new `seq.firmem` work with their existing pipeline. A few commits down the road we'll want to make `HWMemSimImpl` work directly with `seq.firmem` ops, at which point `LowerFirMem` can go away again. At that point tools are expected to have updated their memory passes to work with `seq.firmem` directly, completing the transition. This also adds the `LowerFirMem` pass to the firtool pipeline, but it doesn't do anything yet since nothing in the pipeline currently creates `seq.firmem` ops. This will be changed in a follow-up commit.
fabianschuiki
force-pushed
the
fschuiki/lower-firmem
branch
from
5c04613
to
96ceeb3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add the
LowerFirMempass which lowersseq.firmemops to a correspondinghw.module.generatedop. The pass intends to reflect whatLowerToHWdoes inlowerMemoryDecls: it collects a list of memory ops in the design, distills them down into memory parameters, deduplicates those parameters, creates onehw.module.generatedop for each unique memory config, and replaces the memory ops with instances of this generated module.The
LowerFirMempass is intended as an intermediate solution to allowseq.firmemto be lowered throughHWMemSimImplwithout changing the latter's implementation. Existing tools that have passes operating onhw.module.generated-style memories can simply run theLowerFirMempass and have the newseq.firmemwork with their existing pipeline.A few commits down the road we'll want to make
HWMemSimImplwork directly withseq.firmemops, at which pointLowerFirMemcan go away again. At that point tools are expected to have updated their memory passes to work withseq.firmemdirectly, completing the transition.This also adds the
LowerFirMempass to the firtool pipeline, but it doesn't do anything yet since nothing in the pipeline currently createsseq.firmemops. This will be changed in a follow-up commit.Follow-up work: This pass is just temporary. It will work with
seq.memdirectly onceseq.firmemandseq.hlmemare merged. As soon as HWMemSimImpl and other passes are updated to work withseq.memdirectly themselves, this pass will go away again.