[FIRRTL] Register const updates #5074
Merged
+189
−20
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit disallows register types from being const. Register reset values are allowed to be const or contain const members. In order to efficiently check if a type is const or contains const members, containsConst has been added to RecursiveTypeProperties.
dtzSiFive
reviewed
Apr 26, 2023
| @@ -1148,6 +1152,7 @@ struct circt::firrtl::detail::FVectorTypeStorage | |||
|
|
|||
| /// This holds the bits for the type's recursive properties, and can hold a | |||
| /// pointer to a passive version of the type. | |||
| RecursiveTypeProperties props; | |||
There was a problem hiding this comment.
This is unused and ignored by, e.g., FVectorType::getRecursiveTypeProperties.
There was a problem hiding this comment.
Oof, good catch. Fixed with more extensive tests.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This disallows register types from being const. Register reset values are allowed to be const or contain const members.
In order to efficiently check if a type is const or contains const members, containsConst has been added to RecursiveTypeProperties.