[FIRRTL][LowerTypes] Use agg create ops for unlowered users. #5101
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These are easier to generate and more semantically meaningful
in the IR, compared to the previous bitcast(cat({x_0, ..., x_n})).
This also extends support to work with aggregates of more than
just directly ground types (e.g., vector-of-bundles).
Previously we directly did a cast to FIRRTLBaseType, so explicitly check for that-- also check we're not trying to create an aggregate of or containing references. These scenarios should not occur.
This previously would error/crash, check works multiple levels deep.
darthscsi
approved these changes
Apr 27, 2023
dtzSiFive
deleted the
feature/use-agg-create-ops-for-source-materialization-in-lower-types
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These are easier to generate and more semantically meaningful
in the IR, compared to the previous bitcast(cat({x_0, ..., x_n})).
This also extends support to work with aggregates of more than
just directly ground types (e.g., vector-of-bundles).