Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[HW] Add verifiers for EnumConstantOp and EnumCmpOp #5105

Merged
merged 2 commits into from
Apr 29, 2023
Merged

[HW] Add verifiers for EnumConstantOp and EnumCmpOp #5105

merged 2 commits into from
Apr 29, 2023

Conversation

youngar
Copy link
Member

@youngar youngar commented Apr 28, 2023

No description provided.

@youngar youngar added the HW Involving the `hw` dialect label Apr 28, 2023
dtzSiFive
dtzSiFive approved these changes Apr 28, 2023
View reviewed changes
Copy link
Contributor

@dtzSiFive dtzSiFive left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, please drop the debug print.

lib/Dialect/HW/HWOps.cpp Outdated Show resolved Hide resolved
lib/Dialect/HW/HWOps.cpp Outdated Show resolved Hide resolved
test/Dialect/HW/errors.mlir Outdated Show resolved Hide resolved
@youngar youngar force-pushed the hw-enumcmp branch 2 times, most recently from bd18c80 to 460f86e Compare April 28, 2023 21:58
@youngar youngar merged commit 00ee5ca into llvm:main Apr 29, 2023
@youngar youngar deleted the hw-enumcmp branch April 29, 2023 02:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dtzSiFive dtzSiFive dtzSiFive approved these changes

Assignees
No one assigned
Labels
HW Involving the `hw` dialect
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@youngar @dtzSiFive