[FIRRTL] Hoist common type-property methods up to FIRRTLType. #5125
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dtzSiFive
commented
May 3, 2023
| if (!baseType) | ||
| return false; | ||
|
|
||
| return !baseType.isPassive() || baseType.containsAnalog(); |
There was a problem hiding this comment.
Limiting "isInOut" to FIRRTLBaseType (~= "hardware type") works presently but conceivably other non-hardware-only types might want different answers.
For example, a non-hw aggregate type mixing hardware and not, this (and "is passive") is less clear, to be tackled when adding them (but heads-up). Conservatively saying "no" for non-hw types (as we currently do).
youngar
reviewed
May 3, 2023
trilorez
reviewed
May 3, 2023
trilorez
reviewed
May 3, 2023
Split out queries that are reasonable for all FIRRTLType's, leave the rest in FIRRTLBaseType. Notably: * RefType is not passive, nor ground. * isPassive() and getPassiveType() only on FIRRTLBaseType. * isConst is supported on all FIRRTLType's. Note that RTP is not stored for all types, but make these properties and basic predicates using them, part of all FIRRTLType's.
Per reviewer feedback, thanks!
Per reviewer feedback, thanks!
dtzSiFive
force-pushed
the
feature/hoist-rtp-to-ft
branch
from
b9bcea5
to
d732b1f
Compare
|
Thanks, folks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Split out queries that are reasonable for all FIRRTLType's, leave the rest in FIRRTLBaseType.
Notably:
Note that RTP is not stored for all types, but make these properties and basic
predicates using them, part of all FIRRTLType's.