[DC] Add fork/sink materialization passes #5159
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mortbopet
force-pushed
the
dev/mpetersen/dc_3
branch
from
a581f01
to
5fe81bf
Compare
mortbopet
force-pushed
the
dev/mpetersen/dc_4
branch
from
fba221b
to
a04f644
Compare
mortbopet
force-pushed
the
dev/mpetersen/dc_3
branch
2 times, most recently
from
6c5f33b
to
a81d295
Compare
mortbopet
force-pushed
the
dev/mpetersen/dc_3
branch
from
a81d295
to
6404ef2
Compare
mortbopet
force-pushed
the
dev/mpetersen/dc_4
branch
2 times, most recently
from
1435b75
to
42b2ae7
Compare
mortbopet
force-pushed
the
dev/mpetersen/dc_4
branch
from
42b2ae7
to
dbc7520
Compare
lucas-rami
approved these changes
May 15, 2023
| static LogicalResult addForkOps(Region &r, OpBuilder &rewriter) { | ||
| for (Operation &op : r.getOps()) { | ||
| // Ignore terminators, and don't add Forks to Forks. | ||
| if (op.getNumSuccessors() == 0 && !isa<ForkOp>(op)) { |
There was a problem hiding this comment.
Isn't it possible that a ForkOp instance that was present in the input IR before the fork/sink materialization pass runs has one of its results used multiple times? In that case, it seems we could end up with a value used more than once after the pass is finished. Does the pass assume that no forks/sinks are present in the input IR?
There was a problem hiding this comment.
It shouldn't assume that IMO.
There was a problem hiding this comment.
Most definitely - to create a vague excuse for myself, this code is just duplicated from the Handshake stuff. I'll fix it and add a test for it, good catch 👍
teqdruid
reviewed
May 16, 2023
| static LogicalResult addForkOps(Region &r, OpBuilder &rewriter) { | ||
| for (Operation &op : r.getOps()) { | ||
| // Ignore terminators, and don't add Forks to Forks. | ||
| if (op.getNumSuccessors() == 0 && !isa<ForkOp>(op)) { |
There was a problem hiding this comment.
It shouldn't assume that IMO.
mortbopet
force-pushed
the
dev/mpetersen/dc_4
branch
from
6a34dca
to
63e7bb0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.