[Arc] Dedup: generalize to CallOpInterface #5161
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maerhart
commented
May 9, 2023
Currently, the Dedup pass only considers StateOp as call operations to arcs because this was the only legal way to call an arc until recently. Because there is no additional check that no other operation calls an arc, the pass fails because it potentially dedups an arc that is called by a CallOp which is not updated accordingly. This generalizes to operations that implement the CallOpMutableInterface. It is assumed that all operations that can call an arc, implement this interface.
maerhart
force-pushed
the
dev/maerhart/arc-generalize-dedup
branch
from
4e57c83
to
6954446
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, the Dedup pass only considers StateOp as call operations to arcs because this was the only legal way to call an arc until recently. Because there is no additional check that no other operation calls an arc, the pass fails because it potentially dedups an arc that is called by a CallOp which is not updated accordingly. This generalizes to operations that implement the CallOpMutableInterface. It is assumed that all operations that can call an arc, implement this interface.