[circt-lec] Clean up z3 includes #5186
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add the z3 include directories as system includes, not normal includes, to the circt-lec tool. Including the z3 headers this way will prevent clang from putting out warnings on code in the z3 headers.
rwy7
changed the title
dtzSiFive
approved these changes
May 12, 2023
Z3 is installed on the CI image and circt-lec tests are run as part of the integration tests (also the short ones in each PR). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add the z3 include directories as system includes, not normal includes, to the circt-lec tool. Including the z3 headers this way will prevent clang from putting out warnings on code in the z3 headers.
Also, remove some intermediate variables (
CIRCT_LEC_{INCLUDES,LIBS,SOURCES}).