[Arc] Merge RemoveArcArgsPattern into ArcCanonicalizer #5200
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maerhart
force-pushed
the
dev/maerhart/arc-icmp-pattern
branch
from
ba72569
to
8d0df2d
Compare
It probably makes sense to add this single pattern to the new ArcCanonicalizer pass since it (1) avoids unnecessary traversals of the IR and (2) by applying it iteratively with other patterns more canonicalization opportunities could be enabled and performed.
maerhart
force-pushed
the
dev/maerhart/arc-merge-removearcargs-into-arccanonializer
branch
from
fcc793d
to
a058b06
Compare
maerhart
deleted the
dev/maerhart/arc-merge-removearcargs-into-arccanonializer
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It probably makes sense to add this single pattern to the new ArcCanonicalizer pass since it (1) avoids unnecessary traversals of the IR and (2) by applying it iteratively with other patterns more canonicalization opportunities could be enabled and performed.