Add StringType to FIRRTL dialect #5208
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
uenoku
reviewed
May 17, 2023
rwy7
force-pushed
the
type-phases
branch
2 times, most recently
from
607814d
to
3138977
Compare
dtzSiFive
approved these changes
May 17, 2023
rwy7
force-pushed
the
type-phases
branch
2 times, most recently
from
83d0993
to
62c79ae
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a new StringType to FIRRTL. Strings are used as metadata properties. Although string has an explicit phase, that phase must not be hardware (must be property phased). Ports with string types are input/output properties.