Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[cmake] Gate FILE_SET commands on CAPNP #5265

Merged
merged 1 commit into from
May 25, 2023
Merged

[cmake] Gate FILE_SET commands on CAPNP #5265

merged 1 commit into from
May 25, 2023

Conversation

teqdruid
Copy link
Contributor

No description provided.

@teqdruid teqdruid added the ESI label May 25, 2023
@teqdruid teqdruid linked an issue May 25, 2023 that may be closed by this pull request
ESI/Capnp CMake error #5264
Closed
mikeurbach
mikeurbach approved these changes May 25, 2023
View reviewed changes
Copy link
Contributor

@mikeurbach mikeurbach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense. If you don't want to actually gate these on the capnp flag long term, I guess these can be on different flag, and that flag used in the check for cmake version? This seems fine for now.

@teqdruid teqdruid merged commit 37c3042 into main May 25, 2023
@teqdruid teqdruid deleted the dev/teqdruid/cmake-mitigation branch May 25, 2023 19:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mikeurbach mikeurbach mikeurbach approved these changes

Assignees
No one assigned
Labels
ESI
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

ESI/Capnp CMake error
2 participants
@teqdruid @mikeurbach