[Calyx to FSM]Fix the bug when calyx multi-component design lower to fsm.

[linuxlonelyeagle]

I found this problem while learning circt during this time, and I have solved it.You can see it here.The names of the state machines generated in the calyx-to-fsm pass are all called control. This leads to a problem when designing with multiple components, where components may instantiate the state machines of other components.

[linuxlonelyeagle]

@rachitnigam 😃Hi, I have found the problem and fixed it.

[mikeurbach]

Nice, thanks for working on this! I think this solution makes sense. @mortbopet I believe you initially implemented this. Any concerns?

[mortbopet]

Makes sense to me, thank you for finding and fixing the bug!

[linuxlonelyeagle]

@mikeurbach Thank you!I remember that you answered my question last year.:smiley:

[linuxlonelyeagle]

@mikeurbach @mortbopet I should modify the test case again.

[mikeurbach]

@linuxlonelyeagle looks like some tests will need to be updated. For example, this name will need to be updated:

circt/test/Conversion/CalyxToFSM/lower-seq.mlir

Line 3 in 2a6ecf7

// CHECK: fsm.machine @control()

You can run the tests with ninja check-circt to try it out.

[linuxlonelyeagle]

@linuxlonelyeagle looks like some tests will need to be updated. For example, this name will need to be updated:

circt/test/Conversion/CalyxToFSM/lower-seq.mlir

Line 3 in 2a6ecf7

// CHECK: fsm.machine @control()

You can run the tests with ninja check-circt to try it out.

Thank you.

[linuxlonelyeagle]

I have modified the test and run ninja check-circt on my own machine.I also tested ninja check-circt-integration.There are two error, but this error was already there,not related to the patch.You can view the results below.

Failed Tests (2):
  CIRCT :: Dialect/FSM/variable/top.mlir
  CIRCT :: ESI/system/basic.mlir


Testing Time: 5.65s
  Unsupported: 44
  Passed     : 33
  Failed     :  2

[mikeurbach]

Great. Assuming the tests pass in CI I will merge it.

[rachitnigam]

Awesome, thanks for fixing this @linuxlonelyeagle