[ETC] Don't erase operations used by dead module instances #5357
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
uenoku
commented
Jun 11, 2023
|
|
||
| // Update `opsToErase`. | ||
| if (opsAlive.count(operation)) | ||
| opsToErase.erase(operation); |
There was a problem hiding this comment.
Note that opsToErase is SmallPtrSetImpl so it won't cause an issue like fixed by #5353
uenoku
changed the title
|
I'm going to merge this to unblock release process. A post-commit is welcomed! |
|
Awesome, thanks for the quick fix, it looks good to me. Dealing with these extracted instances has always had annoying corners like this, so thanks for adding a test as well to cover it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #5356. There is an edge case that ETC wrongly erase an extracted operation which is still used by (dead) module instances. This issue can be fixed by appropriately updating
opsToErasebased onopsAiive.inlineInputOnlyis reordered since it depends onopsToErase.