[FIRRTL][CHIRRTL] Add dialect C API #5472
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SpriteOvO
requested review from
darthscsi,
dtzSiFive and
seldridge
as code owners
SpriteOvO
force-pushed
the
firrtl-chirrtl-dialect-c-api
branch
2 times, most recently
from
7c4b2aa
to
6a9d87f
Compare
SpriteOvO
force-pushed
the
firrtl-chirrtl-dialect-c-api
branch
from
6a9d87f
to
21cb6b4
Compare
mikeurbach
reviewed
Jun 26, 2023
There was a problem hiding this comment.
This looks like a good addition. There was a previous PR to add some of the type APIs, but it hasn't merged: #5192. We should figure out if this will subsume that one, or if we should just merge the previous PR, in which case some of this becomes unnecessary.
|
@mikeurbach What #5192 provides is determiners for types, and getters for Aggregate Types, which happens to be missing from this PR - it provides builders only. I think it would be nice to merge that PR as well, if it gets rebase. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds C API for FIRRTL and CHIRRTL dialects, which allows foreign languages to construct FIRRTL through MLIR C API.