Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FIRRTL][CAPI] Add a new function to get ParamDeclAttr #5792

Merged
merged 1 commit into from
Aug 8, 2023
Merged

[FIRRTL][CAPI] Add a new function to get ParamDeclAttr #5792

merged 1 commit into from
Aug 8, 2023

Conversation

SpriteOvO
Copy link
Member

@SpriteOvO SpriteOvO commented Aug 7, 2023 •
edited
Loading

Addition of #5472.

mikeurbach
mikeurbach approved these changes Aug 7, 2023
View reviewed changes
Copy link
Contributor

@mikeurbach mikeurbach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this looks good to go. It would be good to have C API tests for these functions, but I guess those already don't exist.

@SpriteOvO SpriteOvO merged commit 841451f into llvm:main Aug 8, 2023
5 checks passed
@SpriteOvO SpriteOvO deleted the firrtl-c-api-additions branch August 8, 2023 03:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mikeurbach mikeurbach mikeurbach approved these changes

@darthscsi darthscsi Awaiting requested review from darthscsi darthscsi is a code owner

@dtzSiFive dtzSiFive Awaiting requested review from dtzSiFive

@seldridge seldridge Awaiting requested review from seldridge seldridge is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@SpriteOvO @mikeurbach