[InstanceGraph] Speed up instance graph constructions, NFCI #5520
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
uenoku
changed the title
In large designs, it takes non-negligible amount of time to construct instance graphs. This PR removes an unnecessary walk, and make instance operations accumlation parallel. Before: 50.1090 ( 1.6%) 50.1090 ( 6.1%) LowerFIRRTLAnnotations 17.6776 ( 0.6%) 17.6776 ( 2.2%) (A) circt::firrtl::InstanceGraph 16.6704 ( 0.5%) 16.6704 ( 2.0%) LowerIntrinsics 16.6657 ( 0.5%) 16.6657 ( 2.0%) (A) circt::firrtl::InstanceGraph After: 38.6719 ( 1.2%) 38.6719 ( 5.1%) LowerFIRRTLAnnotations 9.4730 ( 0.3%) 9.4730 ( 1.2%) (A) circt::firrtl::InstanceGraph 9.7834 ( 0.3%) 9.7834 ( 1.3%) LowerIntrinsics 9.7817 ( 0.3%) 9.7817 ( 1.3%) (A) circt::firrtl::InstanceGraph
uenoku
force-pushed
the
dev/uenoku/instance-graph
branch
from
7db1eee
to
3ca2579
Compare
youngar
approved these changes
Jun 29, 2023
lib/Dialect/HW/InstanceGraphBase.cpp
Outdated
Comment on lines
59
to
63
| parent->walk<mlir::WalkOrder::PreOrder>([&](HWModuleLike module) { | ||
| moduleToInstances.push_back({module, {}}); | ||
| // Skip. | ||
| return WalkResult::skip(); | ||
| }); |
There was a problem hiding this comment.
I think we can use something like for (auto module : parent->getBody()->getOps<HWModuleLike>()
calebmkim
pushed a commit
to andrewb1999/circt
that referenced
this pull request
Jul 12, 2023
In large designs, it takes non-negligible amount of time to construct instance graphs (especially before dedup in firtool pipeline) since it was visiting entire circuits twice sequentially. This PR removes an unnecessary walk, and make instance operations accumulation parallel. It reduced the graph construction time by 40% in large designs (3~4% reduction in the entire execution time). Before: ``` 50.1090 ( 1.6%) 50.1090 ( 6.1%) LowerFIRRTLAnnotations 17.6776 ( 0.6%) 17.6776 ( 2.2%) (A) circt::firrtl::InstanceGraph 16.6704 ( 0.5%) 16.6704 ( 2.0%) LowerIntrinsics 16.6657 ( 0.5%) 16.6657 ( 2.0%) (A) circt::firrtl::InstanceGraph ``` After: ``` 38.6719 ( 1.2%) 38.6719 ( 5.1%) LowerFIRRTLAnnotations 9.4730 ( 0.3%) 9.4730 ( 1.2%) (A) circt::firrtl::InstanceGraph 9.7834 ( 0.3%) 9.7834 ( 1.3%) LowerIntrinsics 9.7817 ( 0.3%) 9.7817 ( 1.3%) (A) circt::firrtl::InstanceGraph ```
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In large designs, it takes non-negligible amount of time to construct instance graphs (especially before dedup in firtool pipeline) since it was visiting entire circuits twice sequentially. This PR removes an unnecessary walk, and make instance operations accumlation parallel. It reduced graph construction time by 40% in large designs. (3~4% reduction in the entire execution time)
Before:
After: