[HW] Fix instance ops in hw-flatten-io pass
#5537
Conversation
There was a problem hiding this comment.
Does TypeConverter not work for CallLike ops to do this? It seems like if you're updating function args, you'd need to update the call args as well, and I would imagine that's a big use case for type converter.
If not, this seems like a reasonably common enough problem to warrant a helper lib in MLIR...
| return success(); | ||
| } | ||
|
|
||
| mutable DenseSet<hw::InstanceOp> *convertedOps; |
There was a problem hiding this comment.
I don't think mutable is necessary here since the pointer itself isn't modified.
Are you talking about this, and moving that into the type converter source/target materialization code? I actually suspect that this pass could be rewritten to use our |
I had forgotten about that, but yeah. |
No description provided.